Skip to content

Conversation

@andrykonchin
Copy link
Member

Changes:

  • enabled tests passing on TruffleRuby
  • removed truffleruby and keep only truffleruby-head in CI

Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eregon
Copy link
Member

eregon commented Feb 24, 2025

Context: we recently implemented all the new StringScanner methods in TruffleRuby.
Next we plan to upstream https://github.com/oracle/truffleruby/blob/master/lib/truffle/strscan.rb in this repository after improving it to avoid depending on internals.

@kou kou merged commit 4aadfc8 into ruby:master Feb 24, 2025
38 checks passed
@kou
Copy link
Member

kou commented Feb 24, 2025

Great!

hsbt pushed a commit to hsbt/ruby that referenced this pull request Feb 25, 2025
(ruby/strscan#144)

Changes:
- enabled tests passing on TruffleRuby
- removed `truffleruby` and keep only `truffleruby-head` in CI

ruby/strscan@4aadfc8408
hsbt pushed a commit to ruby/ruby that referenced this pull request Feb 25, 2025
(ruby/strscan#144)

Changes:
- enabled tests passing on TruffleRuby
- removed `truffleruby` and keep only `truffleruby-head` in CI

ruby/strscan@4aadfc8408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants